FunctionalHacker/hugo-toha
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix redirections to empty tabs (#290)

Browse source 
Whenever href (url) attribute was omitted or had no value
the click action would do nothing. With no URLs defined and
`target="_blank"` attributes, which were recently added,
anchor tags now redirect users to new blank tabs (side effect).

This PR solves the issues by adding conditions
before applying `target="_blank"` or in some cases by
ommiting entire entities (e.g. the view_certificate button).
This commit is contained in:
Tommy Chu 2021-04-05 18:25:27 +02:00 • committed by GitHub
parent cb3df73d53
commit d6706e05ee
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 16 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
layouts/partials/cards/accomplishments.html
View file

@ -11,7 +11,9 @@
<p>{{ .courseOverview | markdownify }}</p>
</div>
<div class="card-footer">
<a class="btn btn-outline-info ml-1 pl-2 mb-2" href="{{ .certificateURL | default "#"}}" target="_blank" role="button">{{ i18n "view_certificate"}}</a>
{{ if .certificateURL }}
<a class="btn btn-outline-info ml-1 pl-2 mb-2" href="{{ .certificateURL }}" target="_blank" role="button">{{ i18n "view_certificate"}}</a>
{{ end }}
</div>
</div>
</div>

2
layouts/partials/cards/project.html
View file

@ -4,7 +4,7 @@
>
<div class="card mt-1">
<div class="card">
<a class="card-header" href="{{ if .repo }}{{ .repo }}{{ else if .url }}{{ .url }}{{ else }}javascript:void(0){{ end }}" target="_blank">
<a class="card-header" href="{{ if .repo }}{{ .repo }}{{ else if .url }}{{ .url }}{{ else }}javascript:void(0){{ end }}" {{ if or .repo .url }}target="_blank"{{ end }}>
<div>
<div class="d-flex">
{{ if .logo }}

2
layouts/partials/cards/skill.html
View file

@ -1,5 +1,5 @@
<div class="col-xs-12 col-sm-6 col-lg-4 pt-2">
<a class="skill-card-link" href="{{ if .url }}{{ .url }}{{ else }}javascript:void(0){{ end }}" target="_blank">
<a class="skill-card-link" href="{{ if .url }}{{ .url }}{{ else }}javascript:void(0){{ end }}" {{ if .url }}target="_blank"{{ end }}>
<div class="card">
<div class="card-head d-flex">
{{ if .logo }}

8
layouts/partials/sections/education-alt.html
View file

@ -27,7 +27,7 @@
<div class="row">
<div class="col-lg-10 col-md-8">
{{ if .institution.url }}
<h5><a href="{{ .institution.url }}">{{ .institution.name }}</a></h5>
<h5><a href="{{ .institution.url }}" target="_blank">{{ .institution.name }}</a></h5>
{{ else }}
<h5>{{ .institution.name }}</h5>
{{ end }}
@ -43,7 +43,11 @@
<h6 class="text-muted">{{i18n "publications"}}</h6>
<ul>
{{ range .publications }}
<li><a href="{{ .url }} ">{{ .title }}</a></li>
{{ if .url }}
<li><a href="{{ .url }}" target="_blank">{{ .title }}</a></li>
{{ else }}
<li>{{ .title }}</li>
{{ end }}
{{ end }}
</ul>
</div>

6
layouts/partials/sections/education.html
View file

@ -43,7 +43,11 @@
<h6 class="text-muted">{{ i18n "publications"}}</h6>
<ul>
{{ range .publications }}
<li><a href="{{ .url }} " target="_blank">{{ .title }}</a></li>
{{ if .url }}
<li><a href="{{ .url }}" target="_blank">{{ .title }}</a></li>
{{ else }}
<li>{{ .title }}</li>
{{ end }}
{{ end }}
</ul>
</div>